From: Fredrik Tolf <fredrik@dolda2000.com>
Date: Fri, 29 Jun 2012 01:47:06 +0000 (+0200)
Subject: Merge branch 'master' into python3
X-Git-Url: http://dolda2000.com/gitweb/?a=commitdiff_plain;h=ab92e396057cd617b1607f437d860ff89f5780a2;hp=-c;p=wrw.git

Merge branch 'master' into python3

Conflicts:
	wrw/session.py
---

ab92e396057cd617b1607f437d860ff89f5780a2
diff --combined wrw/session.py
index 02d1983,edf8f7d..90d460b
--- a/wrw/session.py
+++ b/wrw/session.py
@@@ -1,5 -1,5 +1,5 @@@
  import threading, time, pickle, random, os
 -import cookie, env
 +from . import cookie, env
  
  __all__ = ["db", "get"]
  
@@@ -11,15 -11,15 +11,15 @@@ def hexencode(str)
  
  def gennonce(length):
      nonce = ""
 -    for i in xrange(length):
 +    for i in range(length):
          nonce += chr(random.randint(0, 255))
      return nonce
  
  class session(object):
-     def __init__(self, expire = 86400 * 7):
+     def __init__(self, lock, expire = 86400 * 7):
          self.id = hexencode(gennonce(16))
          self.dict = {}
-         self.lock = threading.RLock()
+         self.lock = lock
          self.ctime = self.atime = self.mtime = int(time.time())
          self.expire = expire
          self.dctl = set()
@@@ -68,7 -68,10 +68,10 @@@
      def __setstate__(self, st):
          for k, v in st:
              self.__dict__[k] = v
-         self.lock = threading.Lock()
+         # The proper lock is set by the thawer
+ 
+     def __repr__(self):
+         return "<session %s>" % self.id
  
  class db(object):
      def __init__(self, backdb = None, cookiename = "wrwsess", path = "/"):
@@@ -83,19 -86,34 +86,34 @@@
      def clean(self):
          now = int(time.time())
          with self.lock:
-             dlist = []
-             for sess in self.live.values():
-                 if sess.atime + self.freezetime < now:
-                     try:
-                         if sess.dirty():
-                             self.freeze(sess)
-                     except:
-                         if sess.atime + sess.expire < now:
-                             dlist.append(sess)
-                     else:
-                         dlist.append(sess)
-             for sess in dlist:
-                 del self.live[sess.id]
 -            clist = self.live.keys()
++            clist = list(self.live.keys())
+         for sessid in clist:
+             with self.lock:
+                 try:
+                     entry = self.live[sessid]
+                 except KeyError:
+                     continue
+             with entry[0]:
+                 rm = False
+                 if entry[1] == "retired":
+                     pass
+                 elif entry[1] is None:
+                     pass
+                 else:
+                     sess = entry[1]
+                     if sess.atime + self.freezetime < now:
+                         try:
+                             if sess.dirty():
+                                 self.freeze(sess)
+                         except:
+                             if sess.atime + sess.expire < now:
+                                 rm = True
+                         else:
+                             rm = True
+                 if rm:
+                     entry[1] = "retired"
+                     with self.lock:
+                         del self.live[sessid]
  
      def cleanloop(self):
          try:
@@@ -108,40 -126,67 +126,67 @@@
              with self.lock:
                  self.cthread = None
  
-     def fetch(self, req):
-         now = int(time.time())
-         sessid = cookie.get(req, self.cookiename)
-         new = False
+     def _fetch(self, sessid):
+         while True:
+             now = int(time.time())
+             with self.lock:
+                 if sessid in self.live:
+                     entry = self.live[sessid]
+                 else:
+                     entry = self.live[sessid] = [threading.RLock(), None]
+             with entry[0]:
+                 if isinstance(entry[1], session):
+                     entry[1].atime = now
+                     return entry[1]
+                 elif entry[1] == "retired":
+                     continue
+                 elif entry[1] is None:
+                     try:
+                         thawed = self.thaw(sessid)
+                         if thawed.atime + thawed.expire < now:
+                             raise KeyError()
+                         thawed.lock = entry[0]
+                         thawed.atime = now
+                         entry[1] = thawed
+                         return thawed
+                     finally:
+                         if entry[1] is None:
+                             entry[1] = "retired"
+                             with self.lock:
+                                 del self.live[sessid]
+                 else:
+                     raise Exception("Illegal session entry: " + repr(entry[1]))
+ 
+     def checkclean(self):
          with self.lock:
              if self.cthread is None:
                  self.cthread = threading.Thread(target = self.cleanloop)
                  self.cthread.setDaemon(True)
                  self.cthread.start()
-             try:
-                 if sessid is None:
-                     raise KeyError()
-                 elif sessid in self.live:
-                     sess = self.live[sessid]
-                 else:
-                     sess = self.thaw(sessid)
-                     self.live[sessid] = sess
-                 if sess.atime + sess.expire < now:
-                     raise KeyError()
-                 sess.atime = now
-             except KeyError:
-                 sess = session()
-                 new = True
+ 
+     def fetch(self, req):
+         now = int(time.time())
+         sessid = cookie.get(req, self.cookiename)
+         new = False
+         try:
+             if sessid is None:
+                 raise KeyError()
+             sess = self._fetch(sessid)
+         except KeyError:
+             sess = session(threading.RLock())
+             new = True
  
          def ckfreeze(req):
              if sess.dirty():
                  if new:
                      cookie.add(req, self.cookiename, sess.id, self.path)
                      with self.lock:
-                         self.live[sess.id] = sess
+                         self.live[sess.id] = [sess.lock, sess]
                  try:
                      self.freeze(sess)
                  except:
                      pass
+                 self.checkclean()
          req.oncommit(ckfreeze)
          return sess
  
@@@ -151,13 -196,15 +196,15 @@@
          data = self.backdb[sessid]
          try:
              return pickle.loads(data)
 -        except Exception, e:
 +        except:
              raise KeyError()
  
      def freeze(self, sess):
          if self.backdb is None:
              raise TypeError()
-         self.backdb[sess.id] = pickle.dumps(sess, -1)
+         with sess.lock:
+             data = pickle.dumps(sess, -1)
+         self.backdb[sess.id] = data
          sess.frozen()
  
      def get(self, req):